[sr-dev] [PATCH 1/1] websocket: remove libunistring dependency

[Daniel-Constantin Mierla]

Hello,

I wrapped the patch within defines and pushed it to master branch. I 
plan to test it very soon as I need it in some old systems.

To enable it, websocket module has to be compuled with 
EMBEDDED_UTF8_DECODE=1, e.g.:

make modules EMBEDDED_UTF8_DECODE=1 modules=modules/websocket

Cheers,
Daniel

On 05/02/14 10:23, Peter Dunkley wrote:
> Hello,
>
> I have no problem in principle with the patch, I am just wary of 
> changing something that works.  I do Kamailio builds on four (very 
> different) Linux variants (CentOS 6, Fedora 19, Ubuntu 13.10, Rasbian 
> (Debian Wheezy on Raspberry Pi)) and have never had a problem with the 
> libunistring dependency for WebSockets.
>
> The code in the patch looks straight forward, and the information 
> appears compelling, my question was just about verification and 
> testing of this code copied from the webpage before using it to 
> replace something that currently works.
>
> Regards,
>
> Peter
>
>
> On 5 February 2014 08:05, Daniel-Constantin Mierla <miconda at gmail.com 
> <mailto:miconda at gmail.com>> wrote:
>
>     Thanks for update. Can you wrap your patch in some define, so it
>     can be applied while keeping the libunistring as alternative?
>     Something like:
>
>     #ifdef USE_UTF8_EMBEDDED
>      // your code here
>     #else
>      // libunistring function call
>     #endif
>
>     Then it can be pushed without any problem to the master branch,
>     allowing me (and others) to test it easily. After that we can
>     re-evaluate to remove libunistring completely or maybe just make
>     the embedded version default.
>
>     Cheers,
>     Daniel
>
>
>     On 05/02/14 07:45, Timo Teras wrote:
>
>         On Tue, 04 Feb 2014 21:34:35 +0100
>         Daniel-Constantin Mierla <miconda at gmail.com
>         <mailto:miconda at gmail.com>> wrote:
>
>             Was there any resolution on this topic? I would like to
>             get rid of
>             the unnecessary dependency, the code looked fine at a
>             quick check --
>             if it is just about utf8 encoding/decoding.
>
>             Eventually it can be made a compile time switch with
>             defines for both
>             options, keep the code for both cases and be able to
>             easily switch
>             from one to another.
>
>         I think the patch was not 'blessed' yet.
>
>         Peter asked for testing results along the lines of:
>
>             Something as simple as a loop through all possible values
>             calling your
>             function, the libunistring function, and comparing the
>             results would
>             be perfect.
>
>         The calling the function with every possible utf-8 string is
>         impossible test plan.
>
>         Dunno. Perhaps you want to push the patch with dictator hat
>         on, or some
>         sane test plan can be made. For now, I just applied the patch
>         to my
>         local builds and forgot this.
>
>         - Timo
>
>         _______________________________________________
>         sr-dev mailing list
>         sr-dev at lists.sip-router.org <mailto:sr-dev at lists.sip-router.org>
>         http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>
>
>
>     -- 
>     Daniel-Constantin Mierla - http://www.asipto.com
>     http://twitter.com/#!/miconda <http://twitter.com/#%21/miconda> -
>     http://www.linkedin.com/in/miconda
>
>
>
>
> -- 
> Peter Dunkley
> Technical Director
> Crocodile RCS Ltd

-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20140717/5e3d115f/attachment.html>