[sr-dev] Various fixes for Kamailio's IMS code

Carlos Ruiz Díaz carlos.ruizdiaz at gmail.com
Wed Jan 8 13:26:58 CET 2014


Hi Jason,

Ok, I will proceed with that during the week.

Regards,


On Wed, Jan 8, 2014 at 9:20 AM, Jason Penton <jason.penton at smilecoms.com>wrote:

> Hey Carlos,
>
> I think you can put the charging changes into master and remove that
> branch. I am going to do the same for ims_usrloc_pcscf this week. However,
> this is new functionality so will not need to be back-ported...
>
> Cheers
> Jason
>
>
> On Wed, Jan 8, 2014 at 2:18 PM, Carlos Ruiz Díaz <
> carlos.ruizdiaz at gmail.com> wrote:
>
>> Hi,
>>
>> besides of the mentioned points, there are some changes in the
>> tmp/ims_charging branch that includes DB support for ims_charging and
>> ims_usrloc_pcscf.
>>
>> Regards,
>>
>>
>> On Wed, Jan 8, 2014 at 8:58 AM, Hugh Waite <hugh.waite at crocodile-rcs.com>wrote:
>>
>>>  Hi,
>>> Marek Bazler posted a patch to implement SIP Digest authentication and
>>> Carsten said on Sunday he was looking at it. I expect they are the same
>>> though.
>>>
>>> There were a few IMS fixes in December, I was thinking about
>>> cherry-picking them to 4.1 ready for the 4.1.1 release on Thursday, but I
>>> don't want to get in the way of someone else (e.g. the developer that wrote
>>> it) doing the same thing!
>>>
>>> Hugh
>>>
>>>
>>> On 08/01/2014 11:45, Richard Good wrote:
>>>
>>>    Hi Rob
>>>
>>>  Thanks for the fixes, I hope you have everything working now.
>>>
>>>  sem_post issue:  we have had the same issue on Ubuntu and have added
>>> -lpthread to the Makefiles.  We didn't commit as we are not 100% sure of
>>> the impact on other OS'.  Does anyone have any objections to adding
>>> -lpthread to the Makefile of cdp, ims_qos and ims_registrar_pcscf?
>>>
>>>  seg_fault and memory management:  The seg fault has been fixed in the
>>> master branch.  Please feel free to commit the fix to 4.0.  The memory
>>> management does seem odd, this code comes from the OpenIMSCore project,
>>> will have a look and see if I can figure it out.
>>>
>>>  SIP digest: This was accidentally left off as we do not use it - please
>>> feel free to commit.
>>>
>>>  Config file: You are correct these are out of date in 4.0 - Please feel
>>> free to commit the fix to 4.0.  The master branch config files are up to
>>> date.
>>>
>>>  I recommend using the master branch for the time being as there are
>>> still quite a few changes coming through.
>>>
>>> Regards
>>> Richard.
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> On 28 December 2013 23:04, Rob Day <rkd at rkd.me.uk> wrote:
>>>
>>>>  Hi,
>>>>
>>>> I've been trying to set up Kamailio 4.0.5 as a P-CSCF, I-CSCF and
>>>> S-CSCF today, and hit a few issues which I've fixed.
>>>> http://sip-router.org/contribute/ suggests that patches should be
>>>> submitted to this list, so here I am.
>>>>
>>>> The first issue I hit was the sem_post issue that has been reported
>>>> from time to time (
>>>> http://lists.kamailio.org/pipermail/sr-users/2013-January/076554.html)
>>>> - it looks as though sem_post is only included in -lpthread on Ubuntu
>>>> 12.04, not -lrt (
>>>> https://bugs.launchpad.net/ubuntu/+source/manpages/+bug/874418), so
>>>> I've updated some Makefiles to reflect that.
>>>>
>>>> I subsequently hit a segfault when calling pcscf_save: I've tracked
>>>> this down to a while loop that was missing curly braces, and so tried to
>>>> dereference a null pointer. I think there's another bug in this piece of
>>>> code - because h is NULL at the end of the first while loop, we never go
>>>> round the second loop, and so never call free_rr. It looks like even if we
>>>> did, h->parsed has been set to 0 before we try and free it, so nothing
>>>> would happen. I wasn't sure how the memory management here works, though,
>>>> and so haven't tried to change this.
>>>>
>>>> I also found that the ims_auth module didn't handle standard SIP Digest
>>>> authentication on the MAR interface, only AKA and Digest-MD5 (which seems
>>>> to be specific to OpenIMSCore HSS, and not mentioned in the IMS specs).
>>>> Most of the code to allow SIP Digest authentication was already there, so I
>>>> just hooked the last piece in to get it to work. I'm not sure whether this
>>>> counts as a new feature or a bugfix - it's not clear whether this was meant
>>>> to be supported but just missing a piece, or not meant to be supported but
>>>> very easy to add in.
>>>>
>>>> Finally, I was working from the 4.0 nightlies Debian repository, and
>>>> the examples/scsf/kamailio.cfg file for 4.0.x seems to skip authentication.
>>>> It looks like this section has been reworked heavily in 4.1.0, so this may
>>>> be less important - but I put together a different kamailio.cfg based on a
>>>> mailing list post (
>>>> http://lists.sip-router.org/pipermail/sr-users/2013-March/077142.html),
>>>> and it might make sense to use that as the default file for 4.0.x.
>>>>
>>>> The attached patches are against the 4.0 branch in Git (specifically,
>>>> commit 1b98961522fd8a7eb73ecc7d1772541f8b81aabc). I'm happy to apply any
>>>> feedback which more knowledgeable contributors have.
>>>>
>>>> Best regards,
>>>> Rob
>>>>
>>>> _______________________________________________
>>>> sr-dev mailing list
>>>> sr-dev at lists.sip-router.org
>>>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>>>>
>>>>
>>>  This email is subject to the disclaimer of Smile Communications at http://www.smilecoms.com/disclaimer
>>>
>>>
>>> _______________________________________________
>>> sr-dev mailing listsr-dev at lists.sip-router.orghttp://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>>>
>>>
>>>
>>> --
>>> Hugh Waite
>>> Principal Design Engineer
>>> Crocodile RCS Ltd.
>>>
>>>
>>> _______________________________________________
>>> sr-dev mailing list
>>> sr-dev at lists.sip-router.org
>>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>>>
>>>
>>
>>
>> --
>> Carlos
>> http://caruizdiaz.com
>> +595981146623
>>
>> _______________________________________________
>> sr-dev mailing list
>> sr-dev at lists.sip-router.org
>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>>
>>
>
>
> --
>
>  *Jason Penton**Senior Manager: Applications and Services* *Smile
> Communications Pty (Ltd)* *Mobile:* +27 (0) 83 283 7000*Skype:*jason.barry.penton
> jason.penton at smilecoms.com <name.surname at smilecoms.com> www.smilecoms.com
>
>
>  This email is subject to the disclaimer of Smile Communications at http://www.smilecoms.com/disclaimer
>
>
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>
>


-- 
Carlos
http://caruizdiaz.com
+595981146623
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20140108/b3134885/attachment.html>


More information about the sr-dev mailing list