[sr-dev] [tracker] Comment added: fixes for memory leak in TLS module

sip-router bugtracker at sip-router.org
Tue Jan 7 00:33:21 CET 2014


THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#380 - fixes for memory leak in TLS module
User who did this - Daniel-Constantin Mierla (miconda)

----------
I applied most of the part from the patch. I removed:
- history parts in comments - such info is now in git commit message, existing ones across all files are reminiscent from old times and should be removed because are really incomplete
- locking around decrementing the reference count. I don't see any reason to do it - one operation over a volatile int type. If there is, provide more details -- maybe is better to use atomic_t type and atomic ops
- locking around loading the config file - the entire operation is done in one process, with no potential race inside. If I overlooked something, please add your comments

Instead, I added locking around the operation of updating the list with config structures.

I committed the code on master, link to it:

- http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=208934d47ac1585d42029234267bcceab40ae218

Review and when all is ok, I will backport to stable branches.
----------

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=380#comment1266

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.



More information about the sr-dev mailing list