[sr-dev] git:4.1: parser/parse_addr_spec: allow comma in tag parameter

Daniel-Constantin Mierla miconda at gmail.com
Wed Feb 26 19:54:16 CET 2014


Module: sip-router
Branch: 4.1
Commit: f4b178ec5e348c7bd0a4c936a0d72a3702d80146
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f4b178ec5e348c7bd0a4c936a0d72a3702d80146

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date:   Wed Feb 26 19:52:10 2014 +0100

parser/parse_addr_spec: allow comma in tag parameter

- some user agents uses it and it was in older versions

(cherry picked from commit 6156d2572e06fa661ef23face24c38203485d81a)

---

 parser/parse_addr_spec.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/parser/parse_addr_spec.c b/parser/parse_addr_spec.c
index 179c907..9a8e3b3 100644
--- a/parser/parse_addr_spec.c
+++ b/parser/parse_addr_spec.c
@@ -480,9 +480,12 @@ semicolon_add_param:
 							goto error;
 					}
 					break;
-				}
-				else
-				{
+				} else {
+					if(status==S_PARA_VALUE && param->type==TAG_PARAM) {
+						/* if comma is not separator, allow it as part of value
+						 * - some user agents use it */
+						break;
+					}
 					LOG( L_ERR, "ERROR parse_to_param : "
 							"invalid character ',' in status %d: <<%.*s>>\n",
 							status, (int)(tmp-buffer), ZSW(buffer));




More information about the sr-dev mailing list