[sr-dev] git:4.0: tm: safety check for uas callid value when callid_matching is 1

Daniel-Constantin Mierla miconda at gmail.com
Fri Feb 21 00:25:49 CET 2014


Module: sip-router
Branch: 4.0
Commit: ce060959dad97a346046b276633bfbc442aaf1e6
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ce060959dad97a346046b276633bfbc442aaf1e6

Author: Alex Hermann <alex at speakup.nl>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date:   Fri Feb 21 00:10:35 2014 +0100

tm: safety check for uas callid value when callid_matching is 1

- according to the documentation is for UA that cannot match the
  responses when call-id is changed, but is not the case of self
  generated requests
- closes FS#390

(cherry picked from commit 1787b4239f3494fe7a88b0868a807e86a3b92639)
(cherry picked from commit ef478ac0709a9bef99df0818f68b597f39ba7c3b)

---

 modules/tm/t_lookup.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/modules/tm/t_lookup.c b/modules/tm/t_lookup.c
index fec6e8b..db88d0f 100644
--- a/modules/tm/t_lookup.c
+++ b/modules/tm/t_lookup.c
@@ -1013,6 +1013,7 @@ int t_reply_matching( struct sip_msg *p_msg , int *p_branch )
 			continue;
 
 		if (cfg_get(tm, tm_cfg, callid_matching) && 
+				p_cell->uas.request && p_cell->uas.request->callid &&
 		        (p_msg->callid->body.len != p_cell->uas.request->callid->body.len ||
 		         memcmp(p_msg->callid->body.s, p_cell->uas.request->callid->body.s, p_msg->callid->body.len) != 0)
 		) {




More information about the sr-dev mailing list