[sr-dev] [PATCH 1/1] websocket: remove libunistring dependency
timo.teras at iki.fi
Wed Feb 5 07:45:14 CET 2014
On Tue, 04 Feb 2014 21:34:35 +0100
Daniel-Constantin Mierla <miconda at gmail.com> wrote:
> Was there any resolution on this topic? I would like to get rid of
> the unnecessary dependency, the code looked fine at a quick check --
> if it is just about utf8 encoding/decoding.
> Eventually it can be made a compile time switch with defines for both
> options, keep the code for both cases and be able to easily switch
> from one to another.
I think the patch was not 'blessed' yet.
Peter asked for testing results along the lines of:
> Something as simple as a loop through all possible values calling your
> function, the libunistring function, and comparing the results would
> be perfect.
The calling the function with every possible utf-8 string is
impossible test plan.
Dunno. Perhaps you want to push the patch with dictator hat on, or some
sane test plan can be made. For now, I just applied the patch to my
local builds and forgot this.
More information about the sr-dev