[sr-dev] [tracker] Comment added: Bug in tm with topoh modules - segfault on callid comparison.

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#390 - Bug in tm with topoh modules - segfault on callid comparison.
User who did this - Alex Hermann (axlh)

----------
<code>(gdb) p *p_cell->uas.request
Cannot access memory at address 0x0</code>
I'm really wondering how server transaction can exists without a uas.request on that transaction. Preventing the segfault is easy but could someone explain how uas.request can be NULL at this stage, where the reply has already matched the transaction?

<code>
diff --git a/modules/tm/t_lookup.c b/modules/tm/t_lookup.c
index fbc624b..cc1f4f3 100644
--- a/modules/tm/t_lookup.c
+++ b/modules/tm/t_lookup.c
@@ -984,6 +984,7 @@ int t_reply_matching( struct sip_msg *p_msg , int *p_branch )
                        continue;
 
                if (cfg_get(tm, tm_cfg, callid_matching) && 
+                       p_cell->uas.request && p_cell->uas.request->callid &&
                        (p_msg->callid->body.len != p_cell->uas.request->callid->body.len ||
                         memcmp(p_msg->callid->body.s, p_cell->uas.request->callid->body.s, p_msg->callid->body.len) != 0)
                ) {

</code>
----------

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=390#comment1288

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.