[sr-dev] [tracker] Comment added: add support to auth_db to validate source IP address

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#499 - add support to auth_db to validate source IP address
User who did this - Alex Hermann (axlh)

----------
While i value contributions to Kamailio in general, i'm opposed to this one for several reasons, mainly because it is in the wrong place and completely redundant.


  - The module and function are for verifying digest authentication, i don't think IP checking should be part of it. It is illogical and confusing.
  - The functionality is enable by overloading the configuration of a table column name. Not very in intuitive.
  - The function is limited to only a single ip(-range) per username; not very flexible. The already existing method of achieving the very same functionality is already present in the ipops and, in a more flexible way, the permissions module.
  - The functionality is so __very__ trivial to implement in the config script using the ipops module (only taking 2 lines of script), i don't think the additional maintenance burden for the C code is worth it.
  - The added functionality is undocumented.
  - There is no return code to recognize the reason why "authentication" failed.


I don't think this change should be accepted into Kamailio.
----------

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=499#comment1721

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.