[sr-dev] pua_dialoginfo & pua_mwi

[Daniel-Constantin Mierla]

Hello,

patch to json has been pushed.

Then publish your patch to pua_dialoginfo and pua_mwi module somewhere 
(e.g., tracker) and we will review and merge into master branch.

For the new pua_mwi module, once reviewd and all looks ok, you can get 
git commit access, so you can push it yourself and maintain it 
afterwards -- I will send you the appropriate details when it is the 
time for it.

Cheers,
Daniel

On 22/08/14 16:00, Luis Azedo wrote:
> Hi Daniel,
>
> thank you for your reply.
>
> regarding mwi and dialoginfo, we are getting/creating the values that 
> should be published inside the script.
>
> json module patch below
>
> diff --git a/modules/json/json_mod.c b/modules/json/json_mod.c
> index f102927..9fa0ec4 100644
> --- a/modules/json/json_mod.c
> +++ b/modules/json/json_mod.c
> @@ -88,7 +88,7 @@
> }
> if (param_no == 3) {
> -return fixup_free_pvar_null(param, 3);
> +return fixup_free_pvar_null(param, 1);
> }
> LM_ERR("invalid parameter number <%d>\n", param_no);
>
>
>
>
>
> On Fri, Aug 22, 2014 at 2:37 PM, Daniel-Constantin Mierla 
> <miconda at gmail.com <mailto:miconda at gmail.com>> wrote:
>
>     Hello,
>
>     thanks for considering to contribute back to the public project.
>
>     Do you have the patches on some public server? If yes, send the
>     link to them here, otherwise the best way is to upload them on our
>     tracker:
>
>     - http://sip-router.org/tracker/
>
>     New features are included only on devel branch (git master
>     branch). Due to 'stable' branch release policies, new features are
>     not going to be included in 4.0 and 4.1. Next major release (4.2)
>     is expected to be out by mid of October.
>
>     Regarding the new pua_mwi module, considering that kamailio is not
>     tracking voicemail boxes, how is it getting the information?
>
>     And yes, that seems to be a bug in fixup_get_field_free()
>     function, make a git patch for it, send here and I will push it.
>
>     Cheers,
>     Daniel
>
>
>     On 22/08/14 15:11, Luis Azedo wrote:
>>     hi ,
>>
>>     i would like to submit a patch to pua_dialoginfo to expose
>>     the dialog_publish function to the script so that we can
>>     configure something like this in the script.
>>
>>     route[MY_ROUTE]
>>     {
>>        pua_dialoginfo_publish(.......)
>>     }
>>
>>     i also want to provide a new module pua_mwi that publishes mwi info.
>>
>>     what's the proper flow to submit this ? i want to submit it to
>>     4.0 and 4.1 branch.
>>
>>
>>     also, there seems to be a bug in json module on
>>     fixup_get_field_free function
>>     if (param_no == 3) {
>>     return fixup_free_pvar_null(param, 3); <<<== shouldn't this be 1 ?
>>     }
>>
>>
>>     thanks
>>
>>
>>
>>     _______________________________________________
>>     sr-dev mailing list
>>     sr-dev at lists.sip-router.org  <mailto:sr-dev at lists.sip-router.org>
>>     http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>
>     -- 
>     Daniel-Constantin Mierla
>     http://twitter.com/#!/miconda  <http://twitter.com/#%21/miconda>  -http://www.linkedin.com/in/miconda
>     Next Kamailio Advanced Trainings 2014 -http://www.asipto.com
>     Sep 22-25, Berlin, Germany ::: Oct 15-17, San Francisco, USA
>
>

-- 
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Next Kamailio Advanced Trainings 2014 - http://www.asipto.com
Sep 22-25, Berlin, Germany ::: Oct 15-17, San Francisco, USA

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20140822/6a26d5b6/attachment-0001.html>