[sr-dev] [PATCH] modules/sca: use Call-Info for canonical AoR

[Timo Teras]

On Tue, 22 Apr 2014 10:41:02 +0300
Timo Teras <timo.teras at iki.fi> wrote:

> On Fri, 11 Oct 2013 13:30:24 +0300
> Timo Teräs <timo.teras at iki.fi> wrote:
> 
> We've done some testing finally, and found out it was basically
> unusable. The sca_uri was unparsed, but we really want only the host
> part of it.
> 
> The updated patch that I'm currently testing with, is as follows:

This might have an issue still.

> +	/* Prefer Contact header user */
> +	if ( parse_uri( contact_uri.s, contact_uri.len, &puri ) < 0
> ) { LM_ERR( "sca_create_canonical_aor: failed to parse Contact URI "
>  		    "<%.*s>", STR_FMT( &contact_uri ));
>  	    rc = -1;
>  	    goto done;
>  	}
> -    }

Using Contact unconditionally will be wrong if the function is called
with ua_opts that do not match the direction of the message. Is this
ever the case? Or is the ua_opts argument redundant? Could we just
remove the ua_opts and always use 'automatic' way of figuring out the
direction?

- Timo