[sr-dev] git:master: modules/tmx: added $T_reply_flags pv and fixed bug in t_reuse_branch()

Juha Heinanen jh at tutpro.com
Mon Apr 21 16:47:08 CEST 2014


Daniel-Constantin Mierla writes:

> This looks like an invalid patch. A new function is added - 
> pv_get_t_var_branch - and it is never used.

i added when i started to work in $T_branch, but forgot to remove once i
gave up on the idea.

> A new function prototype is added, but function itself is not defined - 
> pv_get_tm_reply_flags.

looks like my private copy is not in sync with master.  i'll fix it.

> And again, I see no relation between reply and branch flags for adding 
> $T_reply_flags. See my email on sr-users, adding $T_branch(key) is 
> better from grouping point of view and in this case doesn't require any 
> environment cloning.

i'll see, if i'm able to implement $T_branch(key).  then also
$T_reply_ruid would need to be renamed to $T_branch(ruid).

-- juha



More information about the sr-dev mailing list