[sr-dev] git:master: maxfwd: max_limit default value set to 70

[Daniel-Constantin Mierla]

On 16/04/14 09:03, Olle E. Johansson wrote:
> I actually think it was a good thing for Kamailio to have a lower default...
>
> Too many devices use "70" and most of the SIP platforms out there should possibly have a lower value
> than 16...
The issue is when upgrading 3.x to newer version, calls to pstn can 
silently (no error) not completing because of gateways using Max-Forward 
value for Hop Counter. In SIP should be ok in most of the cases. I think 
the approach of not forcing something lower by default is good, the 
proxy should not mess that much in changing signaling rules.

Cheers,
Daniel
>
> /O
>
>
> On 16 Apr 2014, at 08:00, Daniel-Constantin Mierla <miconda at gmail.com> wrote:
>
>> Module: sip-router
>> Branch: master
>> Commit: 73c440e87fc256cda99ab572c0a259c13acac700
>> URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=73c440e87fc256cda99ab572c0a259c13acac700
>>
>> Author: Daniel-Constantin Mierla <miconda at gmail.com>
>> Committer: Daniel-Constantin Mierla <miconda at gmail.com>
>> Date:   Wed Apr 16 08:41:51 2014 +0200
>>
>> maxfwd: max_limit default value set to 70
>>
>> - recommended value by RFC
>> - lower value can create issues when terminating to PSTN/ISUP where
>>   can be used to set the Hop Counter
>> - patch by Sebastian Damm, FS#418
>>
>> ---
>>
>> modules/maxfwd/README               |    2 +-
>> modules/maxfwd/doc/maxfwd_admin.xml |    2 +-
>> modules/maxfwd/maxfwd.c             |    2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/modules/maxfwd/README b/modules/maxfwd/README
>> index 764f8f5..f381e66 100644
>> --- a/modules/maxfwd/README
>> +++ b/modules/maxfwd/README
>> @@ -107,7 +107,7 @@ Chapter 1. Admin Guide
>>     MAX-FORWARDS value allowed by RFC 3261. The value can be changed at
>>     runtime.
>>
>> -   Default value is "16".
>> +   Default value is "70".
>>
>>     Example 1.1. Set max_limit parameter
>> ...
>> diff --git a/modules/maxfwd/doc/maxfwd_admin.xml b/modules/maxfwd/doc/maxfwd_admin.xml
>> index f0f3463..3e5812b 100644
>> --- a/modules/maxfwd/doc/maxfwd_admin.xml
>> +++ b/modules/maxfwd/doc/maxfwd_admin.xml
>> @@ -78,7 +78,7 @@
>> 		</para>
>> 		<para>
>> 		<emphasis>
>> -			Default value is <quote>16</quote>.
>> +			Default value is <quote>70</quote>.
>> 		</emphasis>
>> 		</para>
>> 		<example>
>> diff --git a/modules/maxfwd/maxfwd.c b/modules/maxfwd/maxfwd.c
>> index 371a1aa..c835610 100644
>> --- a/modules/maxfwd/maxfwd.c
>> +++ b/modules/maxfwd/maxfwd.c
>> @@ -55,7 +55,7 @@ struct cfg_group_maxfwd {
>> };
>>
>> static struct cfg_group_maxfwd default_maxfwd_cfg = {
>> -	.max_limit=16
>> +	.max_limit=70
>> };
>>
>> static void *maxfwd_cfg = &default_maxfwd_cfg;
>>
>>
>> _______________________________________________
>> sr-dev mailing list
>> sr-dev at lists.sip-router.org
>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda