[sr-dev] git:4.1: modules/sdpops: added sdp_with_transport_like() function

[Daniel-Constantin Mierla]

On 08/04/14 21:39, Juha Heinanen wrote:
> i didn't get any reply to this.
Perhaps would be more visible with a new subject -- your emails don't 
add Re: to subject of replied emails and they look like commit subjects.

>    does anyone have any opinion on the two
> issues raised or is it so that nobody cares about portability and if
> many modules and core re-define the same function?

It should be in one place and would be good to get rid of _GNU_SOURCE 
for this case. A good place will be ut.{h,c} in the core.

Cheers,
Daniel

>
> -- juha
>
>> while doing it, i noticed that several modules use memmem or ser_memmem
>> function.  memmem is built in, but requires
>>
>> #define _GNU_SOURCE
>>
>> it is used by auth_identity module. nathelper, rtpengine, and rttproxy
>> modules (and now also sdpops) as well as parser use ser_memmem and each
>> defines it separately.
>>
>> what is the preferred way to straighten out this mess?  can we assume
>> that kamailio code is non-portable and thus defining _GNU_SOURCE is
>> acceptable.  if not, what is the best place to put ser_memmem so that
>> it is defined only once?
>>
>> -- juha
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda