[sr-dev] git:admorten/sca: modules/sca: fix return value of sca_call_info_uri_update ()

Andrew Mortensen admorten at isc.upenn.edu
Thu Sep 19 19:52:23 CEST 2013


Module: sip-router
Branch: admorten/sca
Commit: d815cdbf97cb6c0cd57bc492eed5aabe378cce80
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d815cdbf97cb6c0cd57bc492eed5aabe378cce80

Author: Andrew Mortensen <admorten at isc.upenn.edu>
Committer: Andrew Mortensen <admorten at isc.upenn.edu>
Date:   Thu Sep 19 13:49:24 2013 -0400

modules/sca: fix return value of sca_call_info_uri_update()

- return value of 0 can bubble up as return value of sca_call_info_update(),
  causing early script termination (exported function returning 0 in script
  is equivalent to "exit")
- report and patch from Timo Teräs

---

 modules/sca/sca_call_info.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/modules/sca/sca_call_info.c b/modules/sca/sca_call_info.c
index 2d36eae..1e5bbfd 100644
--- a/modules/sca/sca_call_info.c
+++ b/modules/sca/sca_call_info.c
@@ -761,7 +761,7 @@ sca_call_info_uri_update( str *aor, sca_call_info *call_info,
 	     STR_FMT( contact_uri ), STR_FMT( call_id ), call_info->index );
 
     if ( !sca_uri_is_shared_appearance( sca, aor )) {
-	return( 0 );
+	return( 1 );
     }
 
     dialog.id.s = dlg_buf;




More information about the sr-dev mailing list