[sr-dev] [tracker] Task changed: Notify has incorrect information when q=0.5 in the Contact header

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has been changed.  The changes are listed below.  For full information about what has changed, visit the URL and click the History tab.

FS#342 - Notify has incorrect information when q=0.5 in the Contact header
User who did this: Daniel-Constantin Mierla (miconda)
Task details edited:
-------
When the ims_registar_scscf module sends a Notify after a deregistration and the contact has q= parameter, the XML contains state terminated for the AOR, and for the contact the state is active.

<code>
<?xml version="1.0"?>
<reginfo xmlns="urn:ietf:params:xml:ns:reginfo" version="1" state="partial">
	<registration aor="sip:+351915639755 at nl.intinfra.com" id="0x2aeaf52ebb80" state="terminated">
		<contact id="0x2aeaf52ebdd0" state="active" event="registered" expires="3558" q="0.500">
			<uri>sip:+351915639755 at 192.168.230.47:5060;ep=192.168.137.206:49856;transport=udp</uri>
		</contact>
	</registration>
</reginfo>
</code>
When q= parameter is not added in the contact field, the XML in the notify contains the following information after deregistration, AOR is terminated and also contact id in the state terminated.

<code>
<?xml version="1.0"?>
<reginfo xmlns="urn:ietf:params:xml:ns:reginfo" version="1" state="partial">
	<registration aor="sip:+31652526347 at nl.intinfra.com" id="0x2b3396aecd60" state="terminated">
		<contact id="0x2b3396af1e60" state="terminated" event="unregistered" expires="0">
			<uri>sip:+31652526347 at 10.38.102.75:49844;transport=tcp</uri>
		</contact>
	</registration>
</reginfo>
</code>

The contact in the XML of the notify seems to be incorrectly constructed when q=.. used in the contact header.

Attached a patch which creates the correct contact info when the subscriber deregisters

-------

More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=342

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.