[sr-dev] [tracker] Comment added: presence_dialoginfo -> force_single doesn't sent most relevant xml

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#341 - presence_dialoginfo -> force_single doesn't sent most relevant xml
User who did this - Daniel-Constantin Mierla (miconda)

----------
The patch doesn't look good. You should put curly braces for the two IF statements:

	if(force_single_dialog)

and

	if (p_root->children) 

Right now, when doing the indentation of the code, the first FOR:

	for(i=0;i<j; i++) {

includes also the second one, which is in an ELSE branch:

			else {	

				/* loop over all bodies and create the aggregated body */
				for(i=0; i<j; i++)

Which looks wrong.

Also, makes no sense to add the prototype in .h file, since the new function you added in used in one .c file. Add it at the beginning of the .c file. Right now makes an unnecessary include in the .h file for a header file from libxml2.

----------

More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=341#comment1084

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.