[sr-dev] [tracker] Task opened: Notify has incorrect information when q=0.5 in the Contact header (Attachment added)

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

A new Flyspray task has been opened.  Details are below. 

User who did this - Michel de Weerd (mweerd) 

Attached to Project - sip-router
Summary - Notify has incorrect information when q=0.5 in the Contact header
Task Type - Bug Report
Category - Modules kamailio
Status - Unconfirmed
Assigned To - 
Operating System - All
Severity - Medium
Priority - Normal
Reported Version - 4.0
Due in Version - Undecided
Due Date - Undecided
Details - When the ims_registar_scscf module sends a Notify after a deregistration and the contact has q= parameter, the XML contains state terminated for the AOR, and for the contact the state is active.

<?xml version="1.0"?>
<reginfo xmlns="urn:ietf:params:xml:ns:reginfo" version="1" state="partial">
	<registration aor="sip:+351915639755 at nl.intinfra.com" id="0x2aeaf52ebb80" state="terminated">
		<contact id="0x2aeaf52ebdd0" state="active" event="registered" expires="3558" q="0.500">
			<uri>sip:+351915639755 at 192.168.230.47:5060;ep=192.168.137.206:49856;transport=udp</uri>
		</contact>
	</registration>
</reginfo>

When q= parameter is not added in the contact field, the XML in the notify contains the following information after deregistration, AOR is terminated and also contact id in the state terminated.

<?xml version="1.0"?>
<reginfo xmlns="urn:ietf:params:xml:ns:reginfo" version="1" state="partial">
	<registration aor="sip:+31652526347 at nl.intinfra.com" id="0x2b3396aecd60" state="terminated">
		<contact id="0x2b3396af1e60" state="terminated" event="unregistered" expires="0">
			<uri>sip:+31652526347 at 10.38.102.75:49844;transport=tcp</uri>
		</contact>
	</registration>
</reginfo>

The contact in the XML of the notify seems to be incorrectly constructed when q=.. used in the contact header.

Attached a patch which creates the correct contact info when the subscriber deregisters


One or more files have been attached.

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=342

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.