[sr-dev] Crash bug freeing To headers

[Alex Balashov]

On 09/13/2013 07:12 AM, Daniel-Constantin Mierla wrote:

> What is the last merge? The backport of the commit I did last time for
> this issue? Just checking to see if there is some custome
> development/modules around.

The patch you made (setting To param list to NULL) was manually applied. 
  Here's the git diff for the entire tree:

[root at gw1 sip-router]# git diff
diff --git a/Makefile.defs b/Makefile.defs
index 15f42ae..c17992b 100644
--- a/Makefile.defs
+++ b/Makefile.defs
@@ -172,7 +172,7 @@ MEMMNG ?= 1
  # memory debugger switcher
  # 0 - off (no-debug mode)
  # 1 - on (debug mode)
-MEMDBG ?= 0
+MEMDBG = 1

  SER_VER = $(shell expr $(VERSION) \* 1000000 + $(PATCHLEVEL) \* 1000 + \
                         $(SUBLEVEL) )
@@ -976,7 +976,7 @@ ifeq        ($(ARCH), x86_64)
  ifeq           ($(CC_NAME), gcc)
                                 C_DEFS+=-DCC_GCC_LIKE_ASM
                                 #common stuff
-                               CFLAGS=-g -O9 -funroll-loops 
-Wcast-align $(PRO
+                               CFLAGS=-g -ggdb3 -ggdb -Wcast-align 
$(PROFILE)
                         #if gcc 4.5+
                         # don't add '-mtune=$(CPU)' - gcc failure
  ifeq                   ($(CC_SHORTVER), 4.5+)
diff --git a/parser/parse_to.c b/parser/parse_to.c
index b97f8b0..93b792c 100644
--- a/parser/parse_to.c
+++ b/parser/parse_to.c
@@ -828,6 +828,8 @@ void free_to_params(struct to_body* const tb)
                 pkg_free(tp);
                 tp=foo;
         }
+
+       tb->param_lst = NULL;
  }


Here's the recent git log:

commit 56e808078325810c7c8c0d436a0f4f51350680b5
Merge: 10da17d 2a224a5
Author: root <root at gw1.sip.us>
Date:   Tue Aug 27 05:54:20 2013 -0400

     Merge branch '4.0' of git://git.sip-router.org/sip-router into 4.0

commit 2a224a569cea270d8db84438f163b9f309569df9
Author: Daniel-Constantin Mierla <miconda at gmail.com>
Date:   Thu Aug 22 00:14:53 2013 +0200

     core: print src address details if initial message parsing fails

     - reported by Juha Heinanen

     (cherry picked from commit 3ccf4b43e81bd2654cb306a3c2cc21b97cb51f62)

commit fd4a2dde96a692c165f382839c3bef8636dfd9e2
Author: Juha Heinanen <jh at tutpro.com>
Date:   Thu Aug 22 08:20:52 2013 +0300

     modules/lcr: added some linefeed chars missing from syslog messages

     - Patch provided by Kevin Scott Adams.
     (cherry picked from commit d03651fb4c3a6b50923029e121eed201fb1ff550)

commit 10da17d5c4261775bd6c354faa17159971df1332
Merge: 9a90ca2 090035c
Author: root <root at gw1.sip.us>
Date:   Sun Aug 18 10:44:58 2013 -0400

     Merge branch '4.0' of git://git.sip-router.org/sip-router into 4.0

commit 090035cafa01bf54c41bc9f1b145fc7b4dbf0e4b
Author: Daniel-Constantin Mierla <miconda at gmail.com>
Date:   Thu Aug 15 15:38:09 2013 +0200

     ChangeLog: updated for v4.0.3

commit a75a8a140e53ef8cee58d670b3954e7ac4cdb1b8
Author: Daniel-Constantin Mierla <miconda at gmail.com>
Date:   Thu Aug 15 15:33:55 2013 +0200

     Makefile.defs: version set to 4.0.3

-- Alex

-- 
Alex Balashov - Principal
Evariste Systems LLC
235 E Ponce de Leon Ave
Suite 106
Decatur, GA 30030
United States
Tel: +1-678-954-0670
Web: http://www.evaristesys.com/, http://www.alexbalashov.com/