[sr-dev] git:master: modules/tm: cosmetic fixes and comment fixes

Jason Penton jason.penton at gmail.com
Tue Oct 29 09:17:51 CET 2013


Ok Daniel,

will fix.

Cheers
Jason


On Tue, Oct 29, 2013 at 10:17 AM, Daniel-Constantin Mierla <
miconda at gmail.com> wrote:

> Hello,
>
> you have to declare variables at the beginning of the function or blocks
> (i.e., { type x; ... }), otherwise the very strict C compilers throw error.
> it should be the same across the other tm code.
>
> Cheers,
> Daniel
>
>
> On 10/29/13 8:50 AM, Jason Penton wrote:
>
>> Module: sip-router
>> Branch: master
>> Commit: 716932aa77a0f22f00d2ccee8a89cd**84b6674f0a
>> URL:    http://git.sip-router.org/cgi-**bin/gitweb.cgi/sip-router/?a=**
>> commit;h=**716932aa77a0f22f00d2ccee8a89cd**84b6674f0a<http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=716932aa77a0f22f00d2ccee8a89cd84b6674f0a>
>>
>> Author: Jason Penton <jason.penton at smilecoms.com>
>> Committer: Jason Penton <jason.penton at smilecoms.com>
>> Date:   Tue Oct 29 09:49:42 2013 +0200
>>
>> modules/tm: cosmetic fixes and comment fixes
>>
>> ---
>>
>>   modules/tm/t_suspend.c |    7 +++----
>>   1 files changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/modules/tm/t_suspend.c b/modules/tm/t_suspend.c
>> index 23fdb03..c9cb01d 100644
>> --- a/modules/tm/t_suspend.c
>> +++ b/modules/tm/t_suspend.c
>> @@ -384,15 +384,14 @@ done:
>>                 /* unref the transaction */
>>                 t_unref(t->uac[branch].reply);
>>                 LOG(L_DBG,"DEBUG: t_continue_reply: Freeing earlier
>> cloned reply\n");
>> -               /* free header's parsed structures that were added by
>> failure handlers */
>>   +             /* free lumps that were added during reply processing */
>>                 del_nonshm_lump( &(t->uac[branch].reply->add_**rm) );
>>                 del_nonshm_lump( &(t->uac[branch].reply->body_**lumps) );
>>                 del_nonshm_lump_rpl( &(t->uac[branch].reply->reply_**lump)
>> );
>>   -             struct hdr_field* hdr;
>> -               struct hdr_field* prev = 0;
>> -               struct hdr_field* tmp = 0;
>> +               /* free header's parsed structures that were added */
>> +               struct hdr_field *hdr, *prev = 0, *tmp = 0;
>>                 for( hdr=t->uac[branch].reply->**headers ; hdr ;
>> hdr=hdr->next ) {
>>                         if ( hdr->parsed && hdr_allocs_parse(hdr) &&
>>                                 (hdr->parsed<(void*)t->uac[**branch].reply
>> ||
>>
>>
>> ______________________________**_________________
>> sr-dev mailing list
>> sr-dev at lists.sip-router.org
>> http://lists.sip-router.org/**cgi-bin/mailman/listinfo/sr-**dev<http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev>
>>
>
>
> --
> Daniel-Constantin Mierla - http://www.asipto.com
> http://twitter.com/#!/miconda - http://www.linkedin.com/in/**miconda<http://www.linkedin.com/in/miconda>
> Kamailio Advanced Trainings - Berlin, Nov 25-28
>   - more details about Kamailio trainings at http://www.asipto.com -
>
>
>
> ______________________________**_________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/**cgi-bin/mailman/listinfo/sr-**dev<http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20131029/d65db674/attachment-0001.html>


More information about the sr-dev mailing list