[sr-dev] [tracker] Comment added: registrar: memory and db get not synced

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#351 - registrar: memory and db get not synced
User who did this - Daniel-Constantin Mierla (miconda)

----------
Second patch doesn't seem good. The memset on &ci should set to 0 the instance and received.

I think the fields that are are set out of the IF block:

<code>
if (_m!=0) {
...
}
</code>

have to be reset. Like:

<code>
if (_m!=0) {
...
+} else {
+		memset( &ci.instance, 0, sizeof(str));
}
</code>

I am not sure if received has to be reset. From a quick look over the code, it can be taken from and avp, which is done first time. If ci.received is reset, probably received_found has to be reset as well. That code about setting ci.received seems to need a bit of a review. I can do it once you do the patches about the issues you found (once they are ready).


----------

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=351#comment1143

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.