[sr-dev] [tracker] Comment added: modules/debugger: be able to log assign actions

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#299 - modules/debugger: be able to log assign actions
User who did this - Daniel-Constantin Mierla (miconda)

----------
dbg_enable_log_assign() is wrong, because _dbg_pvcache is not-NULL always as you declared it in this version. Perhaps you have to add have more values for log_assign, like:
- 0 - completely disabled
- 1 - feature enabled, but not active
- 2 - feature enabled and active (could be 3 if you want to use bits)

It opens the way to make it changeable at runtime via rpc (only to make it active/inactive), if set to 0, should not be changeable.

The dbg pv cache should not keep pvid field, the pointer is long and can be compared directly. For strings makes sense to have an integer id, as strcmp() can be lengthy operation. Here just go and compare the pointers, values are taken in one bus fetch.

Also, you do the hash function over the content of pvspec, not the pointer value, which you try to find. Although it may work, is not that natural. The hash should be over the value that is searched.
----------

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=299#comment913

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.