[sr-dev] [tracker] Comment added: modules/debugger: be able to log assign actions

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#299 - modules/debugger: be able to log assign actions
User who did this - Daniel-Constantin Mierla (miconda)

----------
The first three patches look ok, they can be committed.

For the 4th patch I think the cache has to be in private memory, kept by each process (practically, using pkg and no need anymore for locks). I was thinking a bit more about it, and some modules can add items in PV cache (in the core) at runtime (like app_lua). Although the ones used in config should be core PV cache from startup, still there is a potential that a module uses actions inside at runtime and can end up in some assignment.

By the nature of pv_spec that can have pkg alloc'ed content, keeping in share memory a reference to it might lead to a different process accessing it than the one that added it in core PV cache.

If kept in pkg, the debugger pv assign cache can hold only the pv_spec pointer and the name can be taken computing the offset in core pv cache structure relative to it (or simply keep a pointer to the whole structure or directly to the name).
----------

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=299#comment910

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.