[sr-dev] git:master: dialog: remove unnecessary tm uac struct init

Daniel-Constantin Mierla miconda at gmail.com
Sun May 19 23:19:23 CEST 2013


Module: sip-router
Branch: master
Commit: b867893d0bbdda0c926a7cd0b6b3a46d4324631e
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b867893d0bbdda0c926a7cd0b6b3a46d4324631e

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date:   Sun May 19 23:15:42 2013 +0200

dialog: remove unnecessary tm uac struct init

---

 modules/dialog/dlg_req_within.c |    2 --
 modules/dialog/dlg_transfer.c   |    2 --
 2 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/modules/dialog/dlg_req_within.c b/modules/dialog/dlg_req_within.c
index bdd09eb..0d8a821 100644
--- a/modules/dialog/dlg_req_within.c
+++ b/modules/dialog/dlg_req_within.c
@@ -308,7 +308,6 @@ static inline int send_bye(struct dlg_cell * cell, int dir, str *hdrs)
 		goto err;
 	}
 
-	memset(&uac_r,'\0', sizeof(uac_req_t));
 	set_uac_req(&uac_r, &met, hdrs, NULL, dialog_info, TMCB_LOCAL_COMPLETED,
 				bye_reply_cb, (void*)iuid);
 	result = d_tmb.t_request_within(&uac_r);
@@ -372,7 +371,6 @@ int dlg_send_ka(dlg_cell_t *dlg, int dir, str *hdrs)
 		goto err;
 	}
 
-	memset(&uac_r,'\0', sizeof(uac_req_t));
 	set_uac_req(&uac_r, &met, hdrs, NULL, di, TMCB_LOCAL_COMPLETED,
 				dlg_ka_cb, (void*)iuid);
 	result = d_tmb.t_request_within(&uac_r);
diff --git a/modules/dialog/dlg_transfer.c b/modules/dialog/dlg_transfer.c
index 7245435..80c5c39 100644
--- a/modules/dialog/dlg_transfer.c
+++ b/modules/dialog/dlg_transfer.c
@@ -140,7 +140,6 @@ void dlg_refer_tm_callback(struct cell *t, int type, struct tmcb_params *ps)
 		goto error;
 	}
 
-	memset(&uac_r, '\0', sizeof(uac_req_t));
 	set_uac_req(&uac_r, &met, NULL, NULL, dialog_info, 0, NULL, NULL);
 	result = d_tmb.t_request_within(&uac_r);
 
@@ -198,7 +197,6 @@ static int dlg_refer_callee(dlg_transfer_ctx_t *dtc)
 	memcpy(hdrs.s+23+dlg_bridge_controller.len+CRLF_LEN+dtc->to.len+CRLF_LEN,
 			dlg_bridge_controller.s, dlg_bridge_controller.len);
 
-	memset(&uac_r, '\0', sizeof(uac_req_t));
 	set_uac_req(&uac_r, &met, &hdrs, NULL, dialog_info, TMCB_LOCAL_COMPLETED,
 				dlg_refer_tm_callback, (void*)dtc);
 	result = d_tmb.t_request_within(&uac_r);




More information about the sr-dev mailing list