[sr-dev] uac_replace_to uac_replace_from and quotes

[Konstantin M.]

I see a similar problem in $uac_req(furi):

In 4.0 the following configuration $uac_req(furi)  = "\"My Name\"
<sip:MyNumber@" + $Ri + ":" + $Rp + ">"; produced:
From: My Name <sip:MyNumber at 0.0.0.0:5062>

Nowadays, in dev code it is puts '<' char at the beginning, changing case
and so on, example:

$uac_req(furi)  = "\"My Name\" <sip:MyNumber@" + $Ri + ":" + $Rp + ">";
produced:
From: <"my name" <sip:MyNumber at 0.0.0.0:5062>

$uac_req(furi)      = "\"My Name\" sip:MyNumber@" + $Ri + ":" + $Rp + "";
produced:
From: <"my name" sip:MyNumber at 0.0.0.0:5062>

However, it is works correct when I do not specify a name:
$uac_req(furi)      = "sip:MyNumber@" + $Ri + ":" + $Rp; produced:
From: <sip:MyNumber at 0.0.0.0:5062>








2013/5/15 Daniel-Constantin Mierla <miconda at gmail.com>

>  Hello,
>
> it is ok from my point of view, it looks like a bug otherwise. But please
> add notes in the docbook/readme documentation about this change for each of
> these functions.
>
> Cheers,
> Daniel
>
>
>
> On 5/15/13 2:36 PM, Vicente Hernando wrote:
>
> Hello,
>
> uac_replace_to and uac_replace_from functions can receive two arguments,
> display and uri.
>
> In current implementation two double quotes are automatically added to
> display during fixup.
>
>
> Would it be a better behavior not to add any quotes? If the user wants
> some quotes he should add them by himself.
>
> E.g:
>
> right now, if I get a display "Vicente" from an invite and store it in $fn
> variable, if I call
>
> uac_replace_from($fn, uri_foo)    it produces  ""Vicente"" in the display
> which kamailio complaints about.
>
>
> If we would avoid quotes, uac_replace_from function could accept:
>
> uac_replace_from("Bob", uri)      display = Bob
>
> uac_replace_from("\"Bob\"", uri)    display = "Bob"
>
>
> standard supports quoted strings, not quoted tokens, spaces before and
> after quotes, etc.
>
>
> Attached patch should avoid quotes in uac_replace functons.
>
>
> What are your opinions about this?
>
> Kind regards,
> Vicente.
>
>
>
> _______________________________________________
> sr-dev mailing listsr-dev at lists.sip-router.orghttp://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>
>
> --
> Daniel-Constantin Mierla - http://www.asipto.comhttp://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
> Kamailio Advanced Training, San Francisco, USA - June 24-27, 2013
>   * http://asipto.com/u/katu *
>
>
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20130515/ad1c48f1/attachment-0001.html>