[sr-dev] git:master: tm: fixed warning related to failure branch routing block execution

[Daniel-Constantin Mierla]

Module: sip-router
Branch: master
Commit: 8e644b8e1ccd9c4d6383a2863f9bf247f789a987
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8e644b8e1ccd9c4d6383a2863f9bf247f789a987

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date:   Mon May 13 11:00:08 2013 +0200

tm: fixed warning related to failure branch routing block execution

- routing blocks id are >=1, the condition was always true because the
  field in tm struct is unsigned int
- gcc warning was: comparison is always true due to limited range of data
  type

---

 modules/tm/t_reply.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/modules/tm/t_reply.c b/modules/tm/t_reply.c
index ce36710..0904d7d 100644
--- a/modules/tm/t_reply.c
+++ b/modules/tm/t_reply.c
@@ -1339,7 +1339,7 @@ static enum rps t_should_relay_response( struct cell *Trans , int new_code,
 		 * save of the final reply per branch */
 		Trans->uac[branch].reply = reply;
 		if (unlikely(has_tran_tmcbs( Trans, TMCB_ON_BRANCH_FAILURE_RO|TMCB_ON_BRANCH_FAILURE)
-						|| (Trans->uac[picked_branch].on_branch_failure >= 0) )) {
+						|| (Trans->uac[picked_branch].on_branch_failure) )) {
 			extra_flags=
 				((Trans->uac[branch].request.flags & F_RB_TIMEOUT)?
 							FL_TIMEOUT:0) |