[sr-dev] git:richard.good/diameter_rx_media: ims_qos: fixed memory leak for rx calling

Richard Good richard.good at smilecoms.com
Tue Mar 19 11:59:29 CET 2013


Module: sip-router
Branch: richard.good/diameter_rx_media
Commit: 3073bda916eb9b0b69b9acf5e16aaf4bd77eaddc
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3073bda916eb9b0b69b9acf5e16aaf4bd77eaddc

Author: Richard Good <richard.good at smilecoms.com>
Committer: Richard Good <richard.good at smilecoms.com>
Date:   Tue Mar 19 12:58:18 2013 +0200

ims_qos: fixed memory leak for rx calling

	- Fixed memory leak on rx media calling - when AAR update is received saved_data struct was not free-ed

---

 modules/ims_qos/mod.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/modules/ims_qos/mod.c b/modules/ims_qos/mod.c
index 0d197ed..46a5e9e 100644
--- a/modules/ims_qos/mod.c
+++ b/modules/ims_qos/mod.c
@@ -546,6 +546,8 @@ static int w_rx_aar(struct sip_msg *msg, char* str1, char* bar) {
         LM_DBG("Attached CDP auth session [%.*s] for Rx to dialog in %s mode\n", auth_session->id.len, auth_session->id.s, direction);
     } else {
         LM_DBG("Update AAR session for this dialog in mode %s\n", direction);
+        if (saved_t_data)
+                free_saved_transaction_global_data(saved_t_data); //only free global data if no AARs were sent. if one was sent we have to rely on the callback (CDP) to free
         create_return_code(CSCF_RETURN_TRUE);
         return CSCF_RETURN_TRUE;
     }




More information about the sr-dev mailing list