[sr-dev] [tracker] Comment added: app_lua: add rpc reload command

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#270 - app_lua: add rpc reload command
User who did this - Daniel-Constantin Mierla (miconda)

----------
kmi internal lib does not seem used, you updated the Makefile to link against it.

It is not yet clear how you structured the global version per loaded script vs local version, probably I need more time to analyze the patch.

Anyhow, there are few things that need to be adjusted.
- you added a memset(), the last parameter has to be the same as the allocated size, not as 'size' variable (multiply with sizeof unsigned int)
- the index in the array of scripts is starting with 1, it should be from 0 -- reloading all scripts should be done different, either with no index parameter or maybe a negative value (e.g., -1), 1-based indexes are misleading in C

----------

More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=270#comment789

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.