[sr-dev] git:pd/outbound: modules/registrar: fixed lock usage in unregister()

Peter Dunkley peter.dunkley at crocodile-rcs.com
Fri Mar 15 12:17:52 CET 2013


Module: sip-router
Branch: pd/outbound
Commit: d6eac37fb61a79e7d99b749aa20ff903523ff2d0
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d6eac37fb61a79e7d99b749aa20ff903523ff2d0

Author: Peter Dunkley <peter.dunkley at crocodile-rcs.com>
Committer: Peter Dunkley <peter.dunkley at crocodile-rcs.com>
Date:   Fri Mar 15 11:15:16 2013 +0000

modules/registrar: fixed lock usage in unregister()

---

 modules/registrar/save.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/modules/registrar/save.c b/modules/registrar/save.c
index a164683..9c76ef7 100644
--- a/modules/registrar/save.c
+++ b/modules/registrar/save.c
@@ -988,15 +988,12 @@ int unregister(struct sip_msg* _m, udomain_t* _d, str* _uri, str *_ruid)
 	} else {
 		/* ruid provided - remove a specific contact */
 
-		ul.lock_udomain(_d, &aor);
 		if (ul.get_urecord_by_ruid(_d, ul.get_aorhash(&aor),
 				_ruid, &r, &c) != 0) {
-			ul.unlock_udomain(_d, &aor);
 			LM_WARN("AOR/Contact not found\n");
 			return -1;
 		}
 		if (ul.delete_ucontact(r, c) != 0) {
-			ul.unlock_udomain(_d, &aor);
 			LM_WARN("could not delete contact\n");
 			return -1;
 		}




More information about the sr-dev mailing list