[sr-dev] about registrar outbound modes

[Peter Dunkley]

Most of the known issues with outbound are listed in the completing_outbound page in the devel section of the Kamailio wiki.

There is also a bug relating to how the flow token is used during loose routing of in-dialog requests.

Regards,

Peter

On 9 Mar 2013, at 12:19, Peter Dunkley <peter.dunkley at crocodile-rcs.com> wrote:

> Hi,
> 
> There are a few issues with the outbound support at the moment (found by Olle during SIPit).
> 
> I have been working through that list and adding fixes to the pd/outbound branch and I hope to have all of the known issues sorted by the end of next week.
> 
> I think this issue may already be fixed on that branch.
> 
> Regards,
> 
> Peter
> 
> On 9 Mar 2013, at 08:33, Juha Heinanen <jh at tutpro.com> wrote:
> 
>>> i would like to change mode 1 as follows:
>>> 
>>>  If set to 1 then this module will accept REGISTER requests that do not
>>>  contain a Supported: header with the outbound options-tag. The 200 OK
>>>  response to REGISTER requests that this module generates will contain a
>>>  Require: or Supported: header with the outbound options tag
>>>  depending on if REGISTER requests contain or do not contain,
>>>  respectively, a Supported: header with the outbound options-tag.
>> 
>> the patch below implements this change.  is it ok that i commit it (plus
>> the above change to README)?
>> 
>> -- juha
>> 
>> *** /usr/src/orig/sip-router/modules/registrar/reply.c    2013-02-06 10:56:37.000000000 +0200
>> --- reply.c    2013-03-09 10:25:15.000000000 +0200
>> ***************
>> *** 658,668 ****
>>                 if (add_flow_timer(_m) < 0)
>>                     return -1;
>>             }
>> -            /* Fall-thru */
>> -        case REG_OUTBOUND_SUPPORTED:
>>             if (add_supported(_m, &outbound_str) < 0)
>> !                return -1;
>>             break;
>>         }
>>         break;
>>     case R_OB_UNSUP:
>> --- 658,675 ----
>>                 if (add_flow_timer(_m) < 0)
>>                     return -1;
>>             }
>>             if (add_supported(_m, &outbound_str) < 0)
>> !                return -1;
>>             break;
>> +        case REG_OUTBOUND_SUPPORTED:
>> +            if ((parse_supported(_m) == 0) &&
>> +            (((struct supported_body *)_m->supported->parsed)->supported_all & F_SUPPORTED_OUTBOUND)) {
>> +            if (add_require(_m, &outbound_str) < 0)
>> +                return -1;
>> +            }
>> +            if (add_supported(_m, &outbound_str) < 0)
>> +            return -1;
>> +            break;
>>         }
>>         break;
>>     case R_OB_UNSUP:
>> 
>> _______________________________________________
>> sr-dev mailing list
>> sr-dev at lists.sip-router.org
>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
> 
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev