[sr-dev] [tracker] Task opened: rtpproxy module: rtpproxy_manage(flags, ip) puts garbage into SDP (Attachment added)

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

A new Flyspray task has been opened.  Details are below. 

User who did this - Markus Bucher (MarkCDSys) 

Attached to Project - sip-router
Summary - rtpproxy module: rtpproxy_manage(flags, ip) puts garbage into SDP
Task Type - Bug Report
Category - Module
Status - Unconfirmed
Assigned To - 
Operating System - All
Severity - High
Priority - Normal
Reported Version - Development
Due in Version - Undecided
Due Date - Undecided
Details - Hi,

I tried to use rtpproxy_manage() specifying flags and an IP, but the command seemed to have put binary data into the SDP instead of the specified IP, thus corrupting the SDP-data.

I found that rtpproxy_manage() processes it's parameters differently than rtpproxy_offer() does.
Is this intended?

Anyway, using parameter conversion the way rtpproxy_offer() does (which actually means doing none at all) seems to fix the issue (see attached patch).

I do not have much experience with the parameter procession of kamailio, so I do not know if my patch opens any memory leaks or other problems.
So please take a closer look at the section.


Best Regards,
Markus


One or more files have been attached.

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=273

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.