[sr-dev] entity value with uri schema

[Klaus Darilion]

Sorry, no time at the moment.

Thanks
Klaus

On 15.07.2013 16:11, Daniel-Constantin Mierla wrote:
> Hi Klaus,
>
> do you have time to review if there are other similar places in the
> module (your may know already if yes or no) and apply the patch? If not,
> I will do it sometime soon.
>
> Cheers,
> Daniel
>
> On 7/15/13 10:46 AM, Klaus Darilion wrote:
>> Hi Daniel!
>>
>> I can not remember why I have not added the URI scheme to the entity
>> value. It seems like I just made a mistake and the bug was long time
>> undiscovered.
>>
>> So IMO it should be fine to just add the sip: (maybe sips: in some
>> cases?) always, without using a module parameter.
>>
>> regards
>> Klaus
>>
>> On 12.07.2013 16:43, Daniel-Constantin Mierla wrote:
>>> Hi Klaus,
>>>
>>> there is a patch on tracker to presence_dialoginfo for adding schema (
>>> sip: ) to entity values in generated notify requests, see:
>>>    - http://sip-router.org/tracker/index.php?do=details&task_id=324
>>>
>>> Apparently it is correct, based on examples from RFC, but as you
>>> developed and tested, maybe you remember that was a different reason not
>>> to do so. The question is whether to make this a configuration option or
>>> just add schema always.
>>>
>>> Cheers,
>>> Daniel
>>>
>