[sr-dev] git:tmp/tm_async_reply_support: modules/tm: no need to kill transaction on continue if there are no open branches

Jason Penton jason.penton at gmail.com
Fri Jul 12 08:09:53 CEST 2013


Module: sip-router
Branch: tmp/tm_async_reply_support
Commit: b908ce411329a24d8bbac9191ee1dd4c7af6099b
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b908ce411329a24d8bbac9191ee1dd4c7af6099b

Author: Jason Penton <jason.penton at smilecoms.com>
Committer: Jason Penton <jason.penton at smilecoms.com>
Date:   Thu Jul 11 22:13:40 2013 +0200

modules/tm: no need to kill transaction on continue if there are no open branches

---

 modules/tm/t_suspend.c |   11 ++---------
 1 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/modules/tm/t_suspend.c b/modules/tm/t_suspend.c
index c7e331d..3b03f97 100644
--- a/modules/tm/t_suspend.c
+++ b/modules/tm/t_suspend.c
@@ -294,13 +294,6 @@ int t_continue(unsigned int hash_index, unsigned int label,
 			if (t->uac[branch].last_received < 200)
 				break;
 		}
-
-		if (branch == t->nr_of_outgoings) {
-			/* There is not any open branch so there is
-			 * no chance that a final response will be received. */
-			ret = 0;
-			goto kill_trans;
-		}
 	}
 
 	UNLOCK_ASYNC_CONTINUE(t);
@@ -320,10 +313,10 @@ kill_trans:
 			"reply generation failed\n");
 		/* The transaction must be explicitely released,
 		 * no more timer is running */
-		UNLOCK_REPLIES(t);
+		UNLOCK_ASYNC_CONTINUE(t);
 		t_release_transaction(t);
 	} else {
-		UNLOCK_REPLIES(t);
+		UNLOCK_ASYNC_CONTINUE(t);
 	}
 
 	t_unref(t->uas.request);




More information about the sr-dev mailing list