[sr-dev] dialog is_in_profile is broken

Klaus Darilion klaus.mailinglists at pernau.at
Fri Jan 18 15:14:26 CET 2013


Tested: Works now

Please commit it to 3.3. (no hurry)

Thanks
Klaus

On 17.01.2013 10:04, Daniel-Constantin Mierla wrote:
> Hello,
>
> I pushed a pathc to master branch. If you can test it and all is ok,
> then can be backported -- you can go ahead with that if you need it
> quickly.
>
> Cheers,
> Daniel
>
> On 1/16/13 12:40 PM, Klaus Darilion wrote:
>> Hi! I am just struggling with is_in_profile. I verified that the
>> dilaog is in profile (with MI commands), but the function always
>> returns false.
>>
>> Thus I checked the source code:
>> http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=blob;f=modules_k/dialog/dlg_profile.c;h=5b388d82b8d6abb0581741df3b0a69b42638eab3;hb=HEAD#l603
>>
>>
>> As far as I see this function never returns 1, always -1.
>>
>> It seems it was broken with this commit:
>> http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=blob;f=modules_k/dialog/dlg_profile.c;h=47657638f54a4fc1e9918bbc7219636377f69816;hb=5bdee1ffe820d3e9e75898bb252d1660b4bbad60
>>
>>
>> regards
>> Klaus
>>
>> _______________________________________________
>> sr-dev mailing list
>> sr-dev at lists.sip-router.org
>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>



More information about the sr-dev mailing list