[sr-dev] htable.list

[Daniel-Constantin Mierla]

On 1/8/13 12:29 PM, Olle E. Johansson wrote:
> I've created a new rpc command in htable called htable.list that lists all htables defined.
> Any objections to commit?
It's ok, you can go ahead and commit.

The only comment is about the command name. The modules uses 'dump' for 
showing the content of the hashs tables, but in other modules is 'list' 
for more or less such purpose (e.g., dispatcher). So no conflict here, 
but a different behaviour than other 'list' commands. Maybe we should do 
some name conventions. I was thinking that for your command can be used 
instead 'htable.info', 'htable.summary' or something else ... just an 
idea, ultimately 'htable.list' is fine as well.

Cheers,
Daniel
>
>   /usr/local/sbin/kamcmd htable.list
> {
> 	name: skrep
> 	dbtable:
> 	dbmode: 0
> 	expire: 1202
> 	updateexpire: 1
> 	size: 16384
> }
> {
> 	name: cfilter
> 	dbtable: contactfilter
> 	dbmode: 1
> 	expire: 0
> 	updateexpire: 1
> 	size: 16384
> }
> {
> 	name: lastnumbers
> 	dbtable:
> 	dbmode: 0
> 	expire: 0
> 	updateexpire: 1
> 	size: 16384
> }
>
>
> /O
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda