[sr-dev] [tracker] Comment added: get_body_part2 (parse_body)

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#170 - get_body_part2 (parse_body)
User who did this - Daniel-Constantin Mierla (miconda)

----------
There seems to be an issue in function:

+int part_multipart_headers_cmp (char *buffer,
+				char *end_buffer,
+				unsigned short content_type,
+				unsigned short content_subtype,
+				char *content_id,
+				char *content_length)
+{
+  int error = 0;
+  char *error_msg = NULL;
+
+  char *cpy_c = NULL;
+  char *cpy_d = NULL;
+
+  char *value_ini = NULL;
+  char *value_fin = NULL;
+  unsigned int umime;
+
+  int found = 0;
+  int found_content_type   = 0;
+  int found_content_id     = 0;
+  int found_content_length = 0;
+
+  if ((buffer == NULL) || (end_buffer == NULL)) {
+    error = -1;
+    error_msg = "buffer and/or end_buffer are NULL";
+  } else {
+    *cpy_c = buffer;
+    *cpy_d = end_buffer;

cpy_c and cpy_d are initialized to NULL, but then values are stored at that address (the last two lines above). Did you want to have:

+    cpy_c = buffer;
+    cpy_d = end_buffer;


----------

More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=170#comment776

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.