[sr-dev] [PATCH] Do not make DNS queries for IP address literals

[Daniel-Constantin Mierla]

Hello,

thanks for the patch. It is now committed in master branch.

Cheers,
Daniel

On 2/20/13 4:03 PM, Simon Perreault wrote:
> Hello,
>
> The current DNS code checks, when making an A query, whether the name 
> is in fact an IPv4 address literal. Same for AAAA query with IPv6 
> address literal. This is good.
>
> However, nothing prevents A queries for IPv6 address literals or AAAA 
> queries for IPv4 address literals. This is wrong.
>
> Here's the bug in action (anonymized to protect the innocent):
>
>> 1.2.3.4 -> 5.6.7.8 SIP 830 Request: ACK 
>> sip:foobar at 9.10.11.12:5060;transport=udp
>> 5.6.7.8 -> 1.2.3.4 DNS 72 Standard query AAAA 9.10.11.12
>
> Attached is a simple patch to fix the bug (of which there are three 
> distinct instances).
>
> Comments?
>
> Simon
>
>
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio World Conference, April 16-17, 2013, Berlin
  - http://conference.kamailio.com -

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20130221/97f68f86/attachment.htm>