[sr-dev] git:master: modules/outbound: Fixes the crash but is logically incorrect for outbound

Peter Dunkley peter.dunkley at crocodile-rcs.com
Wed Feb 20 10:50:38 CET 2013


Module: sip-router
Branch: master
Commit: 8d10bcd44834fd6f2a0c41238fd2dc197143c06e
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8d10bcd44834fd6f2a0c41238fd2dc197143c06e

Author: Peter Dunkley <peter.dunkley at crocodile-rcs.com>
Committer: Peter Dunkley <peter.dunkley at crocodile-rcs.com>
Date:   Wed Feb 20 09:49:44 2013 +0000

modules/outbound: Fixes the crash but is logically incorrect for outbound

- Not sure why the crash happened at all - but this fix breaks the outbound logic

Revert "outbound Fix core dump crash"

This reverts commit 6369444761d44526ded2620e33438abb182d2bdc.

---

 modules/outbound/ob_mod.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/modules/outbound/ob_mod.c b/modules/outbound/ob_mod.c
index f7fd63f..caf10f4 100644
--- a/modules/outbound/ob_mod.c
+++ b/modules/outbound/ob_mod.c
@@ -294,7 +294,7 @@ int use_outbound(struct sip_msg *msg)
 
 	/* Look for ;reg-id in REGISTER Contact-URIs and ;ob in any
 	   Contact-URIs */
-	if (msg->contact && parse_headers(msg, HDR_CONTACT_F, 0) != -1)
+	if (msg->contact || parse_headers(msg, HDR_CONTACT_F, 0) != -1)
 	{
 		if (parse_contact(msg->contact) < 0)
 		{




More information about the sr-dev mailing list