[sr-dev] pcscf_is_registered() internals

[Carsten Bock]

Hi Camille,

i've just made the fallback configurable (default: off) in git-master.
I will commit the change later.

Thanks & merry christmas,
Carsten




2013/12/11 Camille Oudot <camille.oudot at orange.com>:
> Le Mon, 9 Dec 2013 23:30:44 +0100,
> Carsten Bock <carsten at ng-voice.com> a écrit :
>
>> Hi Camille,
>>
>> i've changed it in GIT master to the following behaviour:
>>
>> 1) Lookup based on Contact
>> 1a) compare Received-Info (IP, Port, Proto), if Contact was found
>> 2) Fallback to the old behaviour (directly looking for IP, Port,
>> Proto) otherwise.
>
> Hi Carsten,
>
> this looks nice, thanks. As Hugh Waite pointed, getContactP() always
> fails (no fallback) when no Contact header is present, and would
> prevent from using pcscf_is_registered() and pcscf_assert_identity() to
> be used on Contact-less requests. For my use, this is not a problem,
> and I see the fallback method as a potential way to make DoS attacks on
> a P-CSCF, when a lot of contacts are registered, since id does a
> sequential search, so I would rather not use it at all.
>
> Maybe this fallback behavior should be made optional by configuration.
> I'll add this when possible.
>
> Cheers
>
> --
> Camille



-- 
Carsten Bock
CEO (Geschäftsführer)

ng-voice GmbH
Schomburgstr. 80
D-22767 Hamburg / Germany

http://www.ng-voice.com
mailto:carsten at ng-voice.com

Office +49 40 34927219
Fax +49 40 34927220

Sitz der Gesellschaft: Hamburg
Registergericht: Amtsgericht Hamburg, HRB 120189
Geschäftsführer: Carsten Bock
Ust-ID: DE279344284

Hier finden Sie unsere handelsrechtlichen Pflichtangaben:
http://www.ng-voice.com/imprint/