[sr-dev] [tracker] Comment added: Dialog callback on pua_dialoginfo after restart

sip-router bugtracker at sip-router.org
Thu Dec 12 17:52:31 CET 2013


THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#360 - Dialog callback on pua_dialoginfo after restart
User who did this - Daniel-Constantin Mierla (miconda)

----------
Looking at the 02-add-loaded.patch, it seems that dlginfo variable has to be freed in __dialog_created() and __dialog_loaded() to avoid leaks, or did I missed something?

For the last patch, I think the storage in dialog vars should be optional, via module parameters. I don't see where they are used further in the module, but they are probably useful for configuration file logic. I suggest to make the names of dlg vars module parameters, default set to empty. When they are set to a value via modparam, then the module will store them (so default is not storing in variables).
----------

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=360#comment1230

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.



More information about the sr-dev mailing list