[sr-dev] Dispatcher broken by recent change?

Peter Dunkley peter.dunkley at crocodile-rcs.com
Fri Apr 26 22:20:42 CEST 2013


Hello,

It's working now.

Thanks,

Peter

> Hmm ... can you give another try?
>
> Thanks,
> Daniel
>
> On 4/26/13 7:24 PM, Peter Dunkley wrote:
>> I just built master and put it on my system.  I get the same error.
>>
>> Regards,
>>
>> Peter
>>
>> On 26/04/13 18:02, Daniel-Constantin Mierla wrote:
>>> Have you fetched all master? It was a fix to tm related to cached
>>> to/from hooks (now I did another one, but not affecting this
>>> particular case).
>>>
>>> Cheers,
>>> Daniel
>>>
>>> On 4/26/13 6:54 PM, Peter Dunkley wrote:
>>>> Now I am seeing this:
>>>>
>>>> Apr 26 16:53:06 ip-10-244-155-159 /usr/sbin/kamailio[1453]: ERROR:
>>>> dispatcher [dispatch.c:2373]: Setting the state failed
>>>> (sip:...hostname...;transport=tcp>#015#012From:
>>>> <sip:dispatcher at localhost>;tag=5321d9eafaa14338e381e7bce1b7d630-e883#015#012CSeq:
>>>> 10 OPTIONS#015#012Call-ID:
>>>> 5af607122a40848b-1446 at 10.244.155.159#015#012Max-Forwards:
>>>> 70#015#012Content-Length: 0#015#012#015#012, group 1)
>>>>
>>>> On 26/04/13 17:37, Daniel-Constantin Mierla wrote:
>>>>> Hello,
>>>>>
>>>>> it is effect of that commit, because it expected pure sip uri,
>>>>> without angle brackets. I pushed a fix to shift the start by 1 and
>>>>> decrease length by 2 more. Can you try it?
>>>>>
>>>>> But I'm wondering if it would be safer to parse the value of t->to
>>>>> as To header - more processing but safer for further changes in tm
>>>>> local request generating.
>>>>>
>>>>> If anyone wonders, the change was only in master, so no stable
>>>>> branches are affected.
>>>>>
>>>>> Cheers,
>>>>> Daniel
>>>>>
>>>>> On 4/26/13 5:54 PM, Peter Dunkley wrote:
>>>>>> Hello,
>>>>>>
>>>>>> I've been running a test system keeping it fairly close to git
>>>>>> master.
>>>>>>
>>>>>> I did a new build today and installed it and discovered dispatcher
>>>>>> was giving me this error:
>>>>>> Apr 26 15:50:10 ip-10-244-155-159 /usr/sbin/kamailio[1280]: ERROR:
>>>>>> dispatcher [dispatch.c:2373]: Setting the state failed
>>>>>> (<sip:...hostname...=tc, group 1)
>>>>>>
>>>>>> This was working with master as built on 24/04/2013.
>>>>>>
>>>>>> Could it be related to this commit (note the missing "p>" from the
>>>>>> end of the URI in the log message)?
>>>>>>
>>>>>>     Module: sip-router
>>>>>>     Branch: master
>>>>>>     Commit: 4e4b1339bfd3a832f5feeb1d2a2380c7455ec82b
>>>>>>     URL:http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4e4b1339bfd3a832f5feeb1d2a2380c7455ec82b
>>>>>>
>>>>>>     Author: Daniel-Constantin Mierla<miconda at gmail.com>
>>>>>>     Committer: Daniel-Constantin Mierla<miconda at gmail.com>
>>>>>>     Date:   Thu Apr 25 14:50:40 2013 +0200
>>>>>>
>>>>>>     tm: add angle brackets around From/To URI for local generated
>>>>>> requests
>>>>>>
>>>>>>
>>>>>> Regards,
>>>>>>
>>>>>> Peter
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> sr-dev mailing list
>>>>>> sr-dev at lists.sip-router.org
>>>>>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>>>>>
>>>>> --
>>>>> Daniel-Constantin Mierla -http://www.asipto.com
>>>>> http://twitter.com/#!/miconda  -http://www.linkedin.com/in/miconda
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> sr-dev mailing list
>>>>> sr-dev at lists.sip-router.org
>>>>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> sr-dev mailing list
>>>> sr-dev at lists.sip-router.org
>>>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>>>
>>> --
>>> Daniel-Constantin Mierla -http://www.asipto.com
>>> http://twitter.com/#!/miconda  -http://www.linkedin.com/in/miconda
>>>
>>>
>>> _______________________________________________
>>> sr-dev mailing list
>>> sr-dev at lists.sip-router.org
>>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>>
>>
>>
>> _______________________________________________
>> sr-dev mailing list
>> sr-dev at lists.sip-router.org
>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>
> --
> Daniel-Constantin Mierla - http://www.asipto.com
> http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
>
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>


-- 
Peter Dunkley
Technical Director
Crocodile RCS Ltd




More information about the sr-dev mailing list