[sr-dev] use_ob == 2 ?

[Peter Dunkley]

ob_mod.c line 393

On 25/04/13 17:31, Juha Heinanen wrote:
> peter,
>
> rr/save.c has:
>
>   381         int use_ob = rr_obb.use_outbound ? rr_obb.use_outbound(_m) : 0;
>   382         int sips;
>   383
>   384         user.len = 0;
>   385
>   386         if (add_username) {
>   387                 /* check if there is a custom user set */
>   388                 if (get_custom_user(_m, &user) < 0) {
>   389                         if (get_username(_m, &user) < 0) {
>   390                                 LM_ERR("failed to extract username\n");
>   391                                 return -1;
>   392                         }
>   393                 }
>   394         } else if (use_ob == 1) {
>   395                 if (rr_obb.encode_flow_token(&user, _m->rcv) != 0) {
>   396                         LM_ERR("encoding outbound flow-token\n");
>   397                         return -1;
>   398                 }
>   399         } else if (use_ob == 2) {
>   400                 if (copy_flow_token(&user, _m) != 0) {
>   401                         LM_ERR("copying outbound flow-token\n");
>   402                         return -1;
>   403                 }
>   404         }
>
> i have not found that use_outbound would ever return value 2.  is "} else
> if (use_ob == 2) {" part something that can be removed?
>
> -- juha
>
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev