[sr-dev] [tracker] Comment added: Dialog bugs

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#282 - Dialog bugs
User who did this - Eduardo Lejarreta (lejarreta.e)

----------
--- dlg_db_handler.c    2013-04-08 14:52:04.547468090 +0200
+++ dlg_db_handlerOriginal.c.bck        2013-04-04 16:12:07.218042510 +0200
@@ -380,12 +380,6 @@
                        else
                                dlg->tl.timeout -= (unsigned int)time(0);

-                       //LM_INFO("timeout: %u time(0): %u, get_ticks() %u, \n", (unsigned int)(VAL_INT(values+9)), (unsigned int)time(0),  get_ticks()  );
-                       //LM_INFO("current dialog timeout before is %u\n", dlg->tl.timeout);
-
-                       dlg->lifetime = dlg->tl.timeout - get_ticks();
-                       //LM_INFO("LIFETIME IS %u\n", dlg->lifetime);
-
                        GET_STR_VALUE(cseq1, values, 10 , 1, 1);
                        GET_STR_VALUE(cseq2, values, 11 , 1, 1);
                        GET_STR_VALUE(rroute1, values, 12, 0, 0);
@@ -409,8 +403,7 @@
                        dlg_set_toroute(dlg, &toroute_name);

                        /*restore the timer values */
-                       //if (0 != insert_dlg_timer( &(dlg->tl), (int)dlg->tl.timeout )) {
-                       if (0 != insert_dlg_timer( &(dlg->tl), dlg->lifetime )) {
+                       if (0 != insert_dlg_timer( &(dlg->tl), (int)dlg->tl.timeout )) {
                                LM_CRIT("Unable to insert dlg %p [%u:%u] "
                                        "with clid '%.*s' and tags '%.*s' '%.*s'\n",
                                        dlg, dlg->h_entry, dlg->h_id,
@@ -421,11 +414,10 @@
                                continue;
                        }
                        dlg_ref(dlg,1);
+                       LM_DBG("current dialog timeout is %u\n", dlg->tl.timeout);

-                       //LM_INFO("LIFETIME IS %i\n", VAL_INT(values+9)-VAL_INT(values+7));
-                       //dlg->lifetime = VAL_INT(values+9) - VAL_INT(values+7);
+                       dlg->lifetime = 0;
                        dlg->dflags = 0;
-                       dlg->dflags |= DLG_FLAG_TOBYE;
                        next_dialog:
                        ;
                }
@@ -731,9 +723,6 @@
                VAL_INT(values+11)              = (unsigned int)( (unsigned int)time(0) +
                                 cell->tl.timeout - get_ticks() );

-               /*LM_INFO("timeout: %u celltimeout: %u time(0): %u, get_ticks() %u, \n", (unsigned int)( (unsigned int)time(0) +
-                                 cell->tl.timeout - get_ticks() ), cell->tl.timeout, (unsigned int)time(0),  get_ticks()  );*/
-
                SET_STR_VALUE(values+2, cell->callid);
                SET_STR_VALUE(values+3, cell->from_uri);
                SET_STR_VALUE(values+4, cell->tag[DLG_CALLER_LEG]);
@@ -788,9 +777,6 @@
                VAL_INT(values+11)              = (unsigned int)( (unsigned int)time(0) +
                                 cell->tl.timeout - get_ticks() );

-               /*LM_INFO("timeout: %u celltimeout: %u time(0): %u, get_ticks() %u, \n", (unsigned int)( (unsigned int)time(0) +
-                                 cell->tl.timeout - get_ticks() ), cell->tl.timeout, (unsigned int)time(0),  get_ticks()  );*/
-
                SET_STR_VALUE(values+12, cell->cseq[DLG_CALLER_LEG]);
                SET_STR_VALUE(values+13, cell->cseq[DLG_CALLEE_LEG]);


----------

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=282#comment854

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.