[sr-dev] [tracker] Comment added: enable milliseconds precision for accounting

sip-router bugtracker at sip-router.org
Tue Apr 23 20:52:19 CEST 2013


THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#163 - enable milliseconds precision for accounting
User who did this - Daniel-Constantin Mierla (miconda)

----------
Revived from the mailing list -- I see few issues and have some questions:

- the tm variable is declared set, but not used
- tz is also not used, gettimeofday() can take NULL as second parameter and iirc, tz is obsolete
- I wonder if gettimeofday() can actually fail and return code should be checked for error cases
- the names of the new column, respectively 'time_hires' sounds a bit strange to me, does it have any special meaning the word 'hires'?

Overall, wouldn't be better to keep the seconds and microseconds (as returned in a timeval structure) in separate columns. That means keeping the time column as it is and adding a new column for microsecs. Then people can get the precision as they want, including only down to the miliseconds if that is what they need.
----------

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=163#comment850

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.



More information about the sr-dev mailing list