[sr-dev] git:admorten/sca: modules/sca: ensure line-seize sub update uses index from request

Andrew Mortensen admorten at isc.upenn.edu
Wed Apr 3 21:01:41 CEST 2013


Module: sip-router
Branch: admorten/sca
Commit: b6e5d49a00cbbb1aefd8ba91c421029cdac3c1ea
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b6e5d49a00cbbb1aefd8ba91c421029cdac3c1ea

Author: Andrew Mortensen <admorten at isc.upenn.edu>
Committer: Andrew Mortensen <admorten at isc.upenn.edu>
Date:   Wed Apr  3 14:54:36 2013 -0400

modules/sca: ensure line-seize sub update uses index from request

- lazy removal of line-seize subscriptions that were not used for a
  call could lead to failure to release expired seized appearance.
  Client must have a lingering, expired line-seize subscription that
  hasn't yet been purged by the timer, and indices must not match.
  Fix ensures that the appearance-index from the new line-seize
  subscription overwrites the index left over from the expired one.

---

 modules/sca/sca_subscribe.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/modules/sca/sca_subscribe.c b/modules/sca/sca_subscribe.c
index 0698464..f30386a 100644
--- a/modules/sca/sca_subscribe.c
+++ b/modules/sca/sca_subscribe.c
@@ -1161,7 +1161,7 @@ sca_handle_subscribe( sip_msg_t *msg, char *p1, char *p2 )
 				"Invalid Call-Info header", msg );
 		goto done;
 	    }
-	    app_idx = call_info.index;
+	    req_sub.index = app_idx = call_info.index;
 	} else {
 	    SCA_SUB_REPLY_ERROR( sca, 400, "Bad Request - "
 			    "missing Call-Info header", msg );




More information about the sr-dev mailing list