[sr-dev] git:master: b/f: an error would be nice, if the module fails to load ; -)

[Carsten Bock]

Hi Daniel,

you're right, i'll try to remember next time...

Kind regards,
Carsten

2013/4/3 Daniel-Constantin Mierla <miconda at gmail.com>:
> Try to prefix the first line of the commit message with the module name, the
> log will look consistent as every developer does it:
>
> - http://www.kamailio.org/wiki/devel/git-commit-guidelines#commit_message
>
> Then, it does not really look as a bug fix, if that is the meaning of b/f -
> seems just that a log message is added, which is useful, can be even
> backported because helps in the operation procedures, but labeling it a bug
> fix misleads many of us.
>
> Also, getting the commit log full of not technical content such as emoticons
> would look inappropriate in changelogs (distributed in debian and other
> distros, linked in release news, web sites, etc.), I would prefer to have it
> clear and concise to what was fixed or added by that commit.
>
> Cheers,
> Daniel
>
>
> On 4/3/13 12:55 PM, admin at sip-router.org wrote:
>>
>> Module: sip-router
>> Branch: master
>> Commit: befb822c7548c063c9643e8e6b27b1a6e9ff1631
>> URL:
>> http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=befb822c7548c063c9643e8e6b27b1a6e9ff1631
>>
>> Author: Carsten Bock <carsten at ng-voice.com>
>> Committer: Carsten Bock <carsten at ng-voice.com>
>> Date:   Wed Apr  3 12:55:01 2013 +0200
>>
>> b/f: an error would be nice, if the module fails to load ;-)
>>
>> ---
>>
>>   modules/rtpproxy/rtpproxy.c |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/modules/rtpproxy/rtpproxy.c b/modules/rtpproxy/rtpproxy.c
>> index 78f69c0..0f92814 100644
>> --- a/modules/rtpproxy/rtpproxy.c
>> +++ b/modules/rtpproxy/rtpproxy.c
>> @@ -935,12 +935,14 @@ mod_init(void)
>>         }
>>         /* storing the list of rtp proxy sets in shared memory*/
>>         for(i=0;i<rtpp_sets;i++){
>> +               LM_DBG("Adding RTP-Proxy set %d/%d: %s\n", i, rtpp_sets,
>> rtpp_strings[i]);
>>                 if ((rtpp_db_url.s == NULL) &&
>>                     (rtpproxy_add_rtpproxy_set(rtpp_strings[i]) != 0)) {
>>                         for(;i<rtpp_sets;i++)
>>                                 if(rtpp_strings[i])
>>                                         pkg_free(rtpp_strings[i]);
>>                         pkg_free(rtpp_strings);
>> +                       LM_ERR("Failed to add RTP-Proxy from Config!\n");
>>                         return -1;
>>                 }
>>                 if(rtpp_strings[i])
>>
>>
>> _______________________________________________
>> sr-dev mailing list
>> sr-dev at lists.sip-router.org
>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>
>
> --
> Daniel-Constantin Mierla - http://www.asipto.com
> http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
> Kamailio World Conference, April 16-17, 2013, Berlin
>  - http://conference.kamailio.com -
>



-- 
Carsten Bock
CEO (Geschäftsführer)

=============================================================
Visit us on the Kamailio World 2013, April 16th & 17th
=> http://conference.kamailio.com/k01/                             See
you there!
=============================================================

ng-voice GmbH
Schomburgstr. 80
D-22767 Hamburg / Germany

http://www.ng-voice.com
mailto:carsten at ng-voice.com

Office +49 40 34927219
Fax +49 40 34927220

Sitz der Gesellschaft: Hamburg
Registergericht: Amtsgericht Hamburg, HRB 120189
Geschäftsführer: Carsten Bock
Ust-ID: DE279344284

Hier finden Sie unsere handelsrechtlichen Pflichtangaben:
http://www.ng-voice.com/imprint/