[sr-dev] git:3.3 Possible error creating presence tables

[Daniel-Constantin Mierla]

Hello,

you are right, it seems that the sql script was manually edited by Juha, 
it should be auto-generated via:

make dbschema

to avoid any such typos and generate the sql scripts for all database types.

I pushed the commit on branch 3.3.

Cheers,
Daniel

On 9/14/12 12:38 PM, Andrés Souto Vidal wrote:
> Hello,
>
> I think this commit:
> Module: sip-router
> Branch: 3.3
> Commit: 82ca28c8a523c015b69a3c56d02983356faefc54
> URL:http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=82ca28c8a523c015b69a3c56d02983356faefc54
> introduced a bug creating the presence table by kamdbctl.
>
> The problem is the comma in the previous line:
> --- a/utils/kamctl/mysql/presence-create.sql 
> <http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=blob;f=utils/kamctl/mysql/presence-create.sql;h=5584f8e3c54c3dac538bfff5a85ba9ee3d382066;hb=5584f8e3c54c3dac538bfff5a85ba9ee3d382066>
> +++ b/utils/kamctl/mysql/presence-create.sql 
> <http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=blob;f=utils/kamctl/mysql/presence-create.sql;h=7f68249086de1aac358311fbcd232d3fce8b7681;hb=7f68249086de1aac358311fbcd232d3fce8b7681>
> @@ -103,7 
> <http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=blob;f=utils/kamctl/mysql/presence-create.sql;h=5584f8e3c54c3dac538bfff5a85ba9ee3d382066;hb=5584f8e3c54c3dac538bfff5a85ba9ee3d382066#l103> 
> +103,6 
> <http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=blob;f=utils/kamctl/mysql/presence-create.sql;h=7f68249086de1aac358311fbcd232d3fce8b7681;hb=7f68249086de1aac358311fbcd232d3fce8b7681#l103> 
> @@ CREATE TABLE pua (
>      version INT(11) NOT NULL,
>      extra_headers TEXT NOT NULL,
>      CONSTRAINT pua_idx UNIQUE (etag, tuple_id, call_id, from_tag),
> -    CONSTRAINT expires_idx UNIQUE (expires)
>  ) ENGINE=MyISAM;
>
>
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio Advanced Training, Berlin, Nov 5-8, 2012 - http://asipto.com/u/kat
Kamailio Advanced Training, Miami, USA, Nov 12-14, 2012 - http://asipto.com/u/katu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20120914/c262cbb1/attachment.htm>