[sr-dev] git:master: core: corrected some mis-leading error messages

[Henning Westerholt]

Am Mittwoch, 31. Oktober 2012, 19:06:46 schrieb Peter Dunkley:
> core: corrected some mis-leading error messages
> 
> ---
> 
>  msg_translator.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/msg_translator.c b/msg_translator.c
> index 0447bfa..6985418 100644
> --- a/msg_translator.c
> +++ b/msg_translator.c
> @@ -1722,8 +1722,7 @@ char * build_req_buf_from_sip_req( struct sip_msg*
> msg, if (unlikely(via_anchor==0)) goto error00;
>  	line_buf = create_via_hf( &via_len, msg, send_info, &branch);
>  	if (unlikely(!line_buf)){
> -		LOG(L_ERR,"ERROR: build_req_buf_from_sip_req: "
> -					"memory allocation failure\n");
> +		LM_WARN("creating Via header\n");

Hello Peter,

I must admit that I don't understand this log message now. If I understand the 
code correctly then the LM_WARN is printed when no VIA header field could be 
created and execution is stopped. So I'd suggest that we use

LM_ERR("could not create Via header\n"); 

instead of your change.

Best regards,

Henning Westerholt