[sr-dev] [tracker] Task opened: pua_reginfo adds duplicate cseq field in XML body

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

A new Flyspray task has been opened.  Details are below. 

User who did this - Andrew Pogrebennyk (marduk) 

Attached to Project - sip-router
Summary - pua_reginfo adds duplicate cseq field in XML body
Task Type - Bug Report
Category - Core
Status - Unconfirmed
Assigned To - 
Operating System - All
Severity - Low
Priority - Normal
Reported Version - Development
Due in Version - Undecided
Due Date - Undecided
Details - I've had some problems trying to parse reginfo xml in branch 3.3 because of duplicate cseq field. AFAICS it is still there in master.
modules_k/pua_reginfo/usrloc_cb.c:

146                         /* CSeq Attribute */
147                         memset(buf, 0, sizeof(buf));
148                         buf_len = snprintf(buf, sizeof(buf), "%d", ptr->cseq);
149                         xmlNewProp(contact_node, BAD_CAST "cseq", BAD_CAST buf);
150 
151                         /* received Attribute */
152                         memset(buf, 0, sizeof(buf));
153                         buf_len = snprintf(buf, sizeof(buf), "%.*s", ptr->received.len, ptr->received.s);
154                         xmlNewProp(contact_node, BAD_CAST "received", BAD_CAST buf);
155 
156                         /* path Attribute */
157                         memset(buf, 0, sizeof(buf));
158                         buf_len = snprintf(buf, sizeof(buf), "%.*s", ptr->path.len, ptr->path.s);
159                         xmlNewProp(contact_node, BAD_CAST "path", BAD_CAST buf);
160 
161                         /* user_agent Attribute */
162                         memset(buf, 0, sizeof(buf));
163                         buf_len = snprintf(buf, sizeof(buf), "%.*s", ptr->user_agent.len, ptr->user_agent.s);
164                         xmlNewProp(contact_node, BAD_CAST "user_agent", BAD_CAST buf);
165 
166                         /* CSeq Attribute */
167                         memset(buf, 0, sizeof(buf));
168                         buf_len = snprintf(buf, sizeof(buf), "%d", ptr->cseq);
169                         xmlNewProp(contact_node, BAD_CAST "cseq", BAD_CAST buf);


Also there's duplicate default_domain definition in README.
modules_k/pua_reginfo/README:

3.1. default_domain(str)

   The default domain for the registered users to be used when
   constructing the uri for the registrar callback.

   Default value is “NULL”.

   Example 1.1. Set default_domain parameter
....
modparam("pua_bla", "default_domain", "kamailio.org")
....

3.2. default_domain(str)

   The domain to be used to publish information about a user.

   Example 1.2. Set default_domain parameter
....
modparam("pua_reginfo", "default_domain", "kamailio.org")
....



More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=246

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.