[sr-dev] git:master: modules_k/pua: Fixed occasional seg fault in PUA
Peter Dunkley
peter.dunkley at crocodile-rcs.com
Mon Jan 30 12:32:22 CET 2012
Module: sip-router
Branch: master
Commit: 6d30bd740303677711de437c4a3fec15da7344a8
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6d30bd740303677711de437c4a3fec15da7344a8
Author: pd <peter.dunkley at crocodile-rcs.com>
Committer: pd <peter.dunkley at crocodile-rcs.com>
Date: Mon Jan 30 11:28:59 2012 +0000
modules_k/pua: Fixed occasional seg fault in PUA
- This was added by the fix to the race hazards
(Commit ID: e627bc31776b521a1078b2a004e8ed179521cae2)
- It only happens in certain error situations (which should not occur anyway -
these are under investigation now) and was found during an over-weekend
soak test.
- Found and fixed by Paul Pankhurst @ Crocodile RCS
---
modules_k/pua/send_subscribe.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/modules_k/pua/send_subscribe.c b/modules_k/pua/send_subscribe.c
index 7c25bc7..396ac90 100644
--- a/modules_k/pua/send_subscribe.c
+++ b/modules_k/pua/send_subscribe.c
@@ -696,8 +696,11 @@ done:
goto end;
error:
- if (presentity->remote_contact.s) shm_free(presentity->remote_contact.s);
- if (presentity) shm_free(presentity);
+ if (presentity)
+ {
+ if (presentity->remote_contact.s) shm_free(presentity->remote_contact.s);
+ shm_free(presentity);
+ }
end:
More information about the sr-dev
mailing list