[sr-dev] [tracker] Comment added: pua_dialoginfo: set PUBLISH R-URIs via AVPs

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#197 - pua_dialoginfo: set PUBLISH R-URIs via AVPs
User who did this - Daniel-Constantin Mierla (miconda)

----------
As I could see, there is a wrapper dialog_publish_multi(...) which provides the uri parameter further to dialog_publish(...) anyhow. Shared memory operations are done under lock and should be avoided if not necessary. At the moment, all the extra shm ops are done just for one less condition in the wrapper.

The idea of not sending publish in some cases is good, but should be made consistent, imo, not only for the case of using avps for uris. I would use a dialog flag to detect that. So it will work in all cases, besides being a bit more efficient -- searching in avps list to get none means going over all existing avps and comparing the names.

Two more things:
- when using avps, I saw a check against myself condition -- is it necessary to be hardcoded? Shouldn't be done in the config by admin when setting the avps? It will allow more flexibility there to decide if to send or not to a uri -- just don't add it as avp if no publish to it is desired
- is the patch against master branch?
----------

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=197#comment492

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.